fix(visitor-plugin-common): Escape special characters when emitting template literals #10482
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In ECMAScript template literals,
`and\and$are special and therefore need escaping in generation of source text likenew TypedDocumentString(`…`), while still preserving literal${…}as appropriate for fragment references.Related #10480
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Existing tests seem to pass, although
yarn testends with an error for me even before application of these changes:I'm unfamiliar with your test framework and would appreciate suggestions/guidance on how to cover the specific scenario of #10480.
Test Environment:
Checklist: