Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(functions): Ensure quantize() creates required instance TRS attributes for EXT_mesh_gpu_instancing #1586

Merged
merged 2 commits into from
Feb 8, 2025
Merged

fix(functions): Ensure quantize() creates required instance TRS attributes for EXT_mesh_gpu_instancing #1586

merged 2 commits into from
Feb 8, 2025

Conversation

donmccurdy
Copy link
Owner

@donmccurdy donmccurdy commented Dec 17, 2024 •
edited
Loading

@donmccurdy donmccurdy added bug Something isn't working package:functions labels Dec 17, 2024
@donmccurdy donmccurdy added this to the v4.1 milestone Dec 17, 2024
@donmccurdy donmccurdy mentioned this pull request Dec 17, 2024
Closed
@donmccurdy donmccurdy force-pushed the fix/quantize-batch-trs branch from 7c02568 to 83f5b8f Compare February 8, 2025 02:06
@donmccurdy donmccurdy marked this pull request as ready for review February 8, 2025 02:11
@donmccurdy donmccurdy merged commit cd51e6c into main Feb 8, 2025
7 checks passed
@donmccurdy donmccurdy deleted the fix/quantize-batch-trs branch February 8, 2025 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working package:functions
Projects
None yet
Milestone
v4.1
Development

Successfully merging this pull request may close these issues.

"Instance" plus "meshopt" seems to accidentally delete instanced meshes when used with NodeJS and ThreeJS
1 participant
@donmccurdy