[Refactor] Improve locale file checker structure and error handling #632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikergcalvino
changed the title
ikergcalvino
changed the title
ikergcalvino
force-pushed
the
v4.2-dev
branch
from
a69906e to
6979aef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR refactors the locale file verification script to improve readability, structure, and error handling. It addresses part of the improvements discussed in #627.
Changes introduced:
✅ Extracted functions for better modularity (load_json_file, save_json_file, etc.).
✅ Improved error handling for missing files and JSON decoding issues.
✅ Reorganized print statements for a clearer user experience.
✅ Replaced manual file operations with safer, more structured approaches.
This is a small step towards improving maintainability as discussed in #627. Let me know if there's anything else you'd like me to refine! 🚀