Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrating from Restify 4.x to Restify 5.x. Closes #47 #48

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mariopeixoto
Copy link

See #47.

Please review and let me know if this works for you. Since Restify 5.x removed the restify.errors property, I had to use the restify-errors package.

The most important change is that restify-errors don't allow the customization of the body, but it does allow the creation of new errors using the makeConstructor function. So the JSON output will change a little bit from { error: ..., errorDescription: ...} to { code: ..., message: ... }. Does that comply with the specification?

@itsdouges
Copy link

@domenic any word on reviewing at the PR? :)

@bialesdaniel
Copy link

Any update on whether this can be merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants