dolthub/dolt#9530 - Fix auto-increment overflow handling #3103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elianddb
force-pushed
the
elianddb/9530-fix-auto-increment-overflow
branch
from
3cc95a1 to
9b6b168
Compare
elianddb
force-pushed
the
elianddb/9530-fix-auto-increment-overflow
branch
from
7ec1899 to
c840e36
Compare
jycor
approved these changes
Jul 25, 2025
memory/table.go
Outdated
| data.autoIncVal++ | ||
| nextVal := data.autoIncVal + 1 | ||
| if _, inRange, err := newCol.Type.Convert(ctx, nextVal); err == nil && inRange == sql.InRange { | ||
| data.autoIncVal++ |
There was a problem hiding this comment.
Suggested change
| data.autoIncVal++ | |
| data.autoIncVal = nextVal |
memory/table_editor.go
Outdated
| t.ea.TableData().autoIncVal++ // Move onto next autoIncVal | ||
| nextVal := v.(uint64) + 1 | ||
| if _, inRange, err := autoCol.Type.Convert(ctx, nextVal); err == nil && inRange == sql.InRange { | ||
| t.ea.TableData().autoIncVal++ |
There was a problem hiding this comment.
Suggested change
| t.ea.TableData().autoIncVal++ | |
| t.ea.TableData().autoIncVal = nextVal |
memory/table_editor.go
Outdated
| t.ea.TableData().autoIncVal++ // Move onto next autoIncVal | ||
| nextVal := t.ea.TableData().autoIncVal + 1 | ||
| if _, inRange, err := autoCol.Type.Convert(ctx, nextVal); err == nil && inRange == sql.InRange { | ||
| t.ea.TableData().autoIncVal++ |
There was a problem hiding this comment.
Suggested change
| t.ea.TableData().autoIncVal++ | |
| t.ea.TableData().autoIncVal = nextVal |
elianddb
force-pushed
the
elianddb/9530-fix-auto-increment-overflow
branch
6 times, most recently
from
1b05ab9 to
deb57a7
Compare
elianddb
changed the title
Added bounds checking for auto-increment values to prevent overflow beyond data type limits. The fix ensures auto-increment values don't exceed type maximums (e.g., 127 for TINYINT) and correctly throws duplicate key errors instead of allowing overflow. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Removed Skip: true from tests that verify auto-increment behavior at maximum values. Our fix now allows these tests to pass: - Insert max values (127 for TINYINT, 32767 for SMALLINT, etc.) - Verify SHOW CREATE TABLE shows correct AUTO_INCREMENT values - Removed redundant auto_increment_overflow_test.go file Tests now properly validate that AUTO_INCREMENT values don't exceed type limits and display correctly in SHOW CREATE TABLE output. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Inlined bounds checking logic directly where used instead of helper function: - Removed canIncrementAutoIncVal() helper function from table.go - Inlined logic in table_editor.go Insert method (2 locations) - Inlined logic in table.go AddColumn method (1 location) - Used existing colType.Convert() pattern for type checking 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
These tests verify that SHOW CREATE TABLE correctly displays AUTO_INCREMENT values at integer type maximums for unsigned types: - TINYINT UNSIGNED: AUTO_INCREMENT=255 - SMALLINT UNSIGNED: AUTO_INCREMENT=65535 - MEDIUMINT UNSIGNED: AUTO_INCREMENT=16777215 - INT UNSIGNED: AUTO_INCREMENT=4294967295 - BIGINT UNSIGNED: AUTO_INCREMENT=18446744073709551615 Related to dolthub/dolt#9530 auto-increment overflow protection fix. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
elianddb
force-pushed
the
elianddb/9530-fix-auto-increment-overflow
branch
from
ee78132 to
7237ec9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes dolthub/dolt#9530
Added bounds checking for auto-increment values to prevent overflow beyond data type limits. The fix ensures auto-increment values don't exceed type maximums (e.g., 127 for TINYINT) and correctly throws duplicate key errors instead of allowing overflow.