fix(katana-contracts): update piltover #2980
Draft
+7
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2980 +/- ##
=======================================
Coverage 56.99% 56.99%
=======================================
Files 425 425
Lines 56303 56303
=======================================
+ Hits 32088 32089 +1
+ Misses 24215 24214 -1 ☔ View full report in Codecov by Sentry. |
kariy
requested changes
Feb 2, 2025
bin/katana/src/cli/init/mod.rs
Outdated
Comment on lines
28
to
32
| pub struct InitArgs { | ||
| #[arg(long)] | ||
| #[arg(default_value = "false")] | ||
| #[arg(help = "List the chain configs available locally.")] | ||
| pub list: bool, |
There was a problem hiding this comment.
I already added a dedicated command for managing config files #2972. Let's move this over there instead.
kariy
force-pushed
the
katana/piltover-update-deser
branch
from
50f0094 to
3a4ffb3
Compare
kariy
changed the title
katana init
kariy
force-pushed
the
katana/piltover-update-deser
branch
from
ae75910 to
9152f2c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@kariy this PR contains the contract class built on your PR cartridge-gg/piltover#5 rebased on main.
Also added katana init --list and katana init --show-config <chain_id> which I found useful for dev purposes. At your consideration if they are worth being kept.Feature added in #2983 .