-
Notifications
You must be signed in to change notification settings - Fork 10
고희준 2주차 과제 #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
AJKHJ
wants to merge
1
commit into
doit-web-study:main
Choose a base branch
from
AJKHJ:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+41
−18
Open
고희준 2주차 과제 #2
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -31,26 +31,41 @@ public MemberResponse findOneMember(Long memberId) { | |
// TODO : 전체 회원 정보를 조회한다. | ||
public List<MemberResponse> findAllMembers() { | ||
// DB에서 전체 회원 정보를 조회한다. | ||
|
||
List<Member> members = memberRepository.findAll(); | ||
// 조회된 회원 정보를 List<MemberResponse>로 변환하여 반환한다. | ||
return null; | ||
return members.stream() | ||
.map(MemberResponse::from) | ||
.toList(); | ||
} | ||
|
||
// TODO : 회원 이름으로 회원 정보를 조회한다. | ||
public List<MemberResponse> searchMembersWithName(String memberName) { | ||
// DB에서 memberName에 해당하는 회원 정보를 조회한다. | ||
|
||
List<Member> members = memberRepository.findByMemberName(memberName); | ||
// 조회된 회원 정보를 List<MemberResponse>로 변환하여 반환한다. | ||
return null; | ||
return members.stream() | ||
.map(MemberResponse::from) | ||
.toList(); | ||
} | ||
|
||
// TODO : 회원 비밀번호를 변경한다. | ||
public void changePassword(Long memberId, AuthPasswordChangeRequest request) { | ||
// DB에서 memberId에 해당하는 회원 정보를 조회하고, 존재하지 않는다면 IllegalArgumentException을 발생시킨다. | ||
|
||
Member member = memberRepository.findById(memberId) | ||
.orElseThrow(() -> new IllegalArgumentException("존재하지 않습니다.")); | ||
// 조회된 회원 정보의 비밀번호를 변경한다. ( request.getNewPassword()를 이용하여 변경한다. ) | ||
|
||
member.changePassword(request.getOldPassword(), request.getNewPassword()); | ||
// 변경된 회원 정보를 DB에 저장한다. | ||
|
||
memberRepository.save(member); | ||
} | ||
|
||
public void deleteMember(String memberLoginId, String memberName) { | ||
Member member = memberRepository.findByMemberLoginIdAndMemberName(memberLoginId, memberName); | ||
if (member == null) { | ||
throw new IllegalArgumentException("존재하지 않는 회원입니다. 올바른 Id와 이름을 입력하세요."); | ||
} | ||
memberRepository.delete(member); | ||
} | ||
Comment on lines
+63
to
69
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 잘 작성해주셨습니다! 굿굿입니다 |
||
|
||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
깔끔하게 잘 작성해주셨습니다!
한 가지 확장성 측면에서 고려해보자면, 다음과 같이 작성해보아도 좋을 것 같아요
해당 내용을 다루는 좋은 글 공유드리곘습니다.
https://limdingdong.tistory.com/8