Skip to content

최예린 1주차 과제 #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

cyerinn
Copy link

@cyerinn cyerinn commented Oct 1, 2024

당첨자 관리 데이터베이스 테이블

  1. 당첨자 정보 (id, item, name, email)

1

  1. 당첨자 개인정보 (id, 전화번호, 생년월일, 주소)

2

Comment on lines +85 to +89
PrizeWinner findWinner1 = prizeWinnerRepository.findByNameAndItem("고길동","10만원");
PrizeWinner findWinner2 = prizeWinnerRepository.findByNameAndItem("김머머","50만원");

Assertions.assertThat(findWinner1.getName()).isEqualTo("고길동");
Assertions.assertThat(findWinner2.getEmail()).isEqualTo("[email protected]");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

깔끔하게 잘 해내신 것 같습니다.
아래처럼 존재하지 않는 경우도 테스트케이스에 넣으면 좋을것 같습니다.

Suggested change
PrizeWinner findWinner1 = prizeWinnerRepository.findByNameAndItem("고길동","10만원");
PrizeWinner findWinner2 = prizeWinnerRepository.findByNameAndItem("김머머","50만원");
Assertions.assertThat(findWinner1.getName()).isEqualTo("고길동");
Assertions.assertThat(findWinner2.getEmail()).isEqualTo("[email protected]");
PrizeWinner findWinner1 = prizeWinnerRepository.findByNameAndItem("고길동","10만원");
PrizeWinner findWinner2 = prizeWinnerRepository.findByNameAndItem("김머머","50만원");
PrizeWinner findWinner3 = prizeWinnerRepository.findByNameAndItem("스프링","30만원"); // null
Assertions.assertThat(findWinner1.getName()).isEqualTo("고길동");
Assertions.assertThat(findWinner2.getEmail()).isEqualTo("[email protected]");
Assertions.assertThat(findWinner3).isNull();

수고하셨습니다!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants