노승현 1차 과제 #7
Open
노승현 1차 과제 #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjunhub
reviewed
Oct 2, 2024
Comment on lines
+24
to
+26
| private int teamId; | ||
|
|
||
| private String teamName; |
jjunhub
reviewed
Oct 2, 2024
| // Then | ||
| List<Player> Players = PlayerRepository.findAll(); | ||
| Assertions.assertThat(Players).hasSize(5); | ||
| Assertions.assertThat(Players.get(0).getLine()).isEqualTo("미드"); |
jjunhub
reviewed
Oct 2, 2024
Comment on lines
+120
to
+121
| // Then | ||
| Assertions.assertThat(result1).isNull(); //fail |
There was a problem hiding this comment.
요 부분 isNotNull()이 아닐까 싶은데, 혹시 작성하신 뒤에 테스트 클래스의 메소드 왼쪽에 초록색 삼각형 클릭해서 테스트 실행해보셨을까요?
There was a problem hiding this comment.
아하 수업 중에 자세히 다루지 않아서, 그렇게 생각하실 수도 있겠네요!
보통은 테스트가 모두 통과되도록 작성하는 것이 맞습니다. 이유로는 여러 가지가 있습니다.
- 다른 사람이 보기에, 통과되지 않은 테스트에 대해서 현재 문제가 발생한 것인지 의도한 것인지 알수 없습니다.
- 코드 Push 후에 자동으로 배포해주는 시스템을 구축할 때, 모든 테스트에 대해서 정상적으로 통과하는지를 판단하고 보통 배포를 진행합니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
테이블 설명
2024 LCK 서머 팀 정보(id, 팀명, 순위, 승, 승률)
LCK 선수 정보(id, 선수명, 팀id, 팀명, 라인)
선수 정보에 있는 팀 id를 foreign key로 하여 팀 정보를 요청하는 작업까지에는 어려움이 있었다.