Update spec for compiler flags and systemd user #4961
Conversation
There was a problem hiding this comment.
The optflags changes look good (feel free to merge it first), but I was informed that sysusers.d so far is only available on Fedora, so it might break CentOS 10 build (CentOS 9 build is already broken for a different reason) and probably RHEL too:
https://copr.fedorainfracloud.org/coprs/g/pki/master/builds/
Could you add %ifdef for sysusers.d-related code in Fedora and keep the original code for other platforms?
pki.spec
Outdated
| cat >dogtag-pki.sysusers.conf <<EOF | ||
| g pkiuser %{pki_gid} | ||
| u pkiuser %{pki_uid} 'Certificate System' %{pki_homedir} - | ||
| EOF |
There was a problem hiding this comment.
Does the file name need to match the package name (which could be different on different platforms)?
There was a problem hiding this comment.
I have tested on fedora and I was not thinking to this problem. We can use the package name to avoid problem. However, the change should be in the new line 1517 where the file is moved to the final location.
fmarco76
force-pushed
the
updateSpeck
branch
from
55baf17 to
7d21b05
Compare
C and C++ flags are now retrieved from 'optflags' macro. In Fedora this is:
CFLAGS='-O2 -flto=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-U_FORTIFY_SOURCE,-D_FORTIFY_SOURCE=3 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -march=x86-64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -mtls-dialect=gnu2 -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer '
fmarco76
force-pushed
the
updateSpeck
branch
from
7d21b05 to
eeaeb94
Compare
fmarco76
force-pushed
the
updateSpeck
branch
from
eeaeb94 to
60fa8f6
Compare
|
|
@edewata Thanks! |
C and C++ flags are now retrieved from 'optflags' macro. In Fedora this is:
CFLAGS='-O2 -flto=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-U_FORTIFY_SOURCE,-D_FORTIFY_SOURCE=3 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -march=x86-64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -mtls-dialect=gnu2 -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer '
Additionally, user creation is moved to systemd.