Update pkispawn to verify admin cert #4951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmarco76
reviewed
Feb 5, 2025
|
Hmm.. let me take a look. |
The pki nss-cert-verify has been added to verify that a cert is issued by a trusted CA. The cert can be provided in an NSS database, in a file, or via standard input. The PKITrustManager class has been moved into pki-common.jar such that it can be used by the CLI. This class is not yet officially supported so it's not necessary to provide an upgrade script. The NSSDatabase.verify_cert() has been added to verify a cert using pki nss-cert-verify. The PKIDeployer.import_system_certs() and setup_admin_cert() have been modified to verify the admin cert provided during installation. The test for installing CA with existing certs has been updated to install the CA with a self-signed admin cert (which should fail), then install it again with a CA-signed cert (which should work).
|
|
@fmarco76 I've updated the code to verify the admin cert after importing the cert chain so it should work now. Please see the updated PR. Thanks! |
edewata
commented
Feb 5, 2025
| # Import admin cert after importing the cert chain so that | ||
| # it can be verified. | ||
|
|
||
| if subsystem.name in ['kra', 'ocsp']: |
There was a problem hiding this comment.
I'm actually not sure why in the original code the admin cert import was only done for KRA & OCSP and not for TKS & TPS. It's possible that this code is actually redundant since the same tests for TKS & TPS seem to be working just fine without it. We can clean it up separately later.
|
@fmarco76 Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
pki nss-cert-verifyhas been added to verify that a cert is issued by a trusted CA. The cert can be provided in an NSS database, in a file, or via standard input.The
PKITrustManagerclass has been moved intopki-common.jarsuch that it can be used by the CLI. This class is not yet officially supported so it's not necessary to provide an upgrade script.The
NSSDatabase.verify_cert()has been added to verify a cert usingpki nss-cert-verify.The
PKIDeployer.import_system_certs()andsetup_admin_cert()have been modified to verify the admin cert provided during installation.The test for installing CA with existing certs has been updated to install the CA with a self-signed admin cert (which should fail), then install it again with a CA-signed cert (which should work).
https://github.com/edewata/pki/blob/install/docs/changes/v11.6.0/API-Changes.adoc
https://github.com/edewata/pki/blob/install/docs/changes/v11.6.0/Packaging-Changes.adoc