Fix CI failures #4675
Merged
Fix CI failures #4675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Azure pipeline has been updated to install the latest JSS, LDAP SDK, and IdM Console Framework from Quay since they might not be released yet into the official Fedora repository. The default value for REGISTRY_NAMESPACE has been changed from the repository owner to 'dogtagpki' such that the pipeline can run properly without having to set up a private repository in Quay. The RPM spec file has been modified to depend on maven-local since maven-local-openjdk17 is not available on CentOS/RHEL.
fmarco76
approved these changes
Feb 21, 2024
| @@ -155,7 +155,7 @@ BuildRequires: policycoreutils | |||
|
|
|||
| # Java build dependencies | |||
| BuildRequires: %{java_devel} | |||
| BuildRequires: maven-local-openjdk17 | |||
There was a problem hiding this comment.
Which is the jdk installed in this case?
There was a problem hiding this comment.
The java_devel is still defined as java-17-openjdk-devel, so it should install OpenJDK 17.
The Maven dependency was originally defined as maven-local, which works fine on Fedora 39, but on Fedora 40 it seems to be pulling OpenJDK 21 in addition to OpenJDK 17. I was trying to complete Fedora 40 support first and then add OpenJDK 21 support separately later, so I changed the dependency to maven-local-openjdk17 specifically, but apparently this package is not available on CentOS/RHEL, so for now it's reverted back to maven-local.
|
@fmarco76 Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Azure pipeline has been updated to install the latest JSS, LDAP SDK, and IdM Console Framework from Quay since they might not be released yet into the official Fedora repository.
The default value for
REGISTRY_NAMESPACEhas been changed from the repository owner todogtagpkisuch that the pipeline can run properly without having to set up a private repository in Quay.The RPM spec file has been modified to depend on
maven-localsincemaven-local-openjdk17is not available on CentOS/RHEL.