Remove unnecessary assert in PK11MessageDigest.c #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ASSERT_OUTOFMEM(env) is incorrect for two reasons:
1. When JSS_RefByteArray detects a zero-length result, it returns
false but doesn't throw an exception. It is up to the caller to
handle that as they wish. In our case, we can safely skip the
PK11_DigestOp call.
2. When length < offset+len (and JSS_RefByteArray exits
successfully), we won't have thrown an exception.
This only shows up in debug builds; release builds aren't affected.
Signed-off-by: Alexander Scheel <[email protected]>
cipherboy
added
Bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This
ASSERT_OUTOFMEM(env)is incorrect for two reasons:JSS_RefByteArraydetects a zero-length result, it returnsfalse but doesn't throw an exception. It is up to the caller to
handle that as they wish. In our case, we can safely skip the
PK11_DigestOpcall.length < offset+len(andJSS_RefByteArrayexitssuccessfully), we won't have thrown an exception.
This only shows up in debug builds; release builds aren't affected.
This bug was detected by CI after merging the CMAC changes (#259).
Signed-off-by: Alexander Scheel <[email protected]>