Finish creating SymmetricKeys from byte arrays #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the SHA-2 variants were initially added (SHA2-256, SHA2-384, and SHA2-512), they weren't added to either SymmetricKey or PKCS11Algorithm. This fixes that, allowing Algorithm identifiers to be mapped to PKCS11Constant values, and also to be used as symmetric keys. Signed-off-by: Alexander Scheel <[email protected]>
Each usage in SymmetricKey.Usages maps to a specific PKCS11Constant with prefix "CKA_" (which is of type CK_ATTRIBUTE_TYPE). These constants can be directly used with the underlying PKCS#11 interface via JNI. Signed-off-by: Alexander Scheel <[email protected]>
cipherboy
added
enhancement
|
Generally looks fine, but I'd defer to @jmagne. |
jmagne
reviewed
Sep 20, 2019
jmagne
approved these changes
Sep 20, 2019
Signed-off-by: Alexander Scheel <[email protected]>
Signed-off-by: Alexander Scheel <[email protected]>
cipherboy
force-pushed
the
symkey-from-byte-array
branch
from
b1fbd77 to
66952b6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the course of #259, I wanted to finish creating a
PK11SymKeyfrom a byte array. In doing so, I realized that, when we specify aSecretKeySpec, we do the import correctly already in ourSecretKeyFactoryimplementation,JSSSecretKeyFactorySpi. However, what is missing is support for a few newer HMAC variants.This PR does the following things:
SymmetricKey.UsagetoPKCS11Constantsvalues. This is currently unused, but could be used in the future.SymmetricKey.Types... mostly for HMAC. Otherwise, you'd pass one name toSecretKeyFactoryand another toSecretKeySpec.