feat: add withComment method to add comments#7079
Closed
simivar wants to merge 1 commit intodoctrine:4.4.xfrom
Closed
feat: add withComment method to add comments#7079simivar wants to merge 1 commit intodoctrine:4.4.xfrom
simivar wants to merge 1 commit intodoctrine:4.4.xfrom
Conversation
Member
|
We don't accept new features on the 3.10.x branch anymore. Please target 4.4.x. |
derrabus
requested changes
Aug 7, 2025
Member
derrabus
left a comment
derrabus
left a comment
There was a problem hiding this comment.
This PR does not contain a functional test. Our functional tests are executed on an actual database. In your case, a functional test would show me that a query with a comment built with your modified query builder is actually executable.
| private function getComments(): string | ||
| { | ||
| return implode('', array_map(function ($comment) { | ||
| return sprintf('/* %s */ ', $comment); |
Member
There was a problem hiding this comment.
Do all database engines support this syntax for comments?
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR provides new
withCommentmethod that adds a comment at the top of query. It works for queries and statements.