fix(#6525): do not silently ignore parameters from query builder union parts #6683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your PR. Did you follow the discussion on the issue you've linked? For me, the conclusion was that we don't want to merge parameters. |
|
All right, I've just caught up the other discussion. Sorry for the confusion. Looks like we maintainers did not agree on how to review your PR. I hope that did not frustrate you too much. Let's use #6525 to discuss how merging parameters should be implemented. |
nio-dtp
force-pushed
the
fix-6525-do-not-ignore-parameters-from-qb-union-parts
branch
from
639db83 to
09e5c08
Compare
nio-dtp
force-pushed
the
fix-6525-do-not-ignore-parameters-from-qb-union-parts
branch
from
09e5c08 to
9e6c631
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
If parameters are set to query builder union parts, do not silently ignore them. Do merge inners with outer query before executing it.