feat: add support for function as default value #6441
Conversation
|
Also, please keep in mind that we only allow bugfixes on the 3.8.x branch. Your change however adds new functionality. For that, please target 4.1.x. |
vencakrecl
force-pushed
the
default-value
branch
6 times, most recently
from
d61d985 to
24a2b4a
Compare
vencakrecl
force-pushed
the
default-value
branch
2 times, most recently
from
6e4e4ea to
fee7382
Compare
|
Schema comparison is still not covered. |
| self::assertTrue( | ||
| $sm->createComparator() | ||
| ->compareTables($table, $onlineTable) | ||
| ->isEmpty(), | ||
| ); |
There was a problem hiding this comment.
This is good! Now, what happens if the introspected table…
- … has no default?
- … has a literal value as default?
- … has
NULLas default? - … has a different expression as default?
In that case, we would expect the schema manager to execute the proper SQL to migrate the deployed table and we need to verify that this migration performed successfully.
This has to be covered with tests as well.
Sames goes for the opposite direction: The schema deployed to the database has a column with a default expression and we want to change that to a literal, NULL, no default or a different expression.
|
There hasn't been any activity on this pull request in the past 90 days, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 7 days. |
Summary
Added support for function as default value, for example
id UUID NOT NULL DEFAULT gen_random_uuid()