SQLServer - fix unicode support for text type - nvarchar(max) instead of varchar(max)

src/Platforms/SQLServerPlatform.php

@@ -899,7 +899,7 @@ public function getAsciiStringTypeDeclarationSQL(array $column): string
      */
     public function getClobTypeDeclarationSQL(array $column): string
     {
-        return 'VARCHAR(MAX)';
+        return 'NVARCHAR(MAX)';
     }
 
     /**

src/Schema/SQLServerSchemaManager.php

@@ -89,7 +89,9 @@ protected function _getPortableTableColumnDefinition(array $tableColumn): Column
                 break;
 
             case 'nvarchar':
+                // TEXT type is returned as NVARCHAR(MAX) with a length of -1
                 if ($length === -1) {
+                    $dbType = 'text';
                     break;
                 }
 
@@ -98,7 +100,9 @@ protected function _getPortableTableColumnDefinition(array $tableColumn): Column
                 break;
 
             case 'varchar':
-                // TEXT type is returned as VARCHAR(MAX) with a length of -1
+                // keep for backward compatibility
+                // as some fields might come back as VARCHAR(MAX) with a length of -1
+                // and we want them to be mapped to the 'text' type
                 if ($length === -1) {
                     $dbType = 'text';
                 }

tests/Platforms/SQLServerPlatformTest.php

@@ -120,9 +120,9 @@ public function testGeneratesTypeDeclarationForIntegers(): void
 
     public function testGeneratesTypeDeclarationsForStrings(): void
     {
-        self::assertSame('VARCHAR(MAX)', $this->platform->getClobTypeDeclarationSQL([]));
+        self::assertSame('NVARCHAR(MAX)', $this->platform->getClobTypeDeclarationSQL([]));
         self::assertSame(
-            'VARCHAR(MAX)',
+            'NVARCHAR(MAX)',
             $this->platform->getClobTypeDeclarationSQL(['length' => 5, 'fixed' => true]),
         );
     }