Returning file *path* as ->getDatabase() for SQLite

[ThomasLandauer]

Q	A
Type	improvement
BC Break	?
Fixed issues	none

Summary

I'm suggesting to return the file path as "database name" for SQLite (instead of nothing)

Right now, when loading fixtures, the CLI prompt reads:

Careful, database "" will be purged. Do you want to continue? (yes/no)

This is due to LoadDataFixturesDoctrineCommand::execute() at https://github.com/doctrine/DoctrineFixturesBundle/blob/3.4.x/Command/LoadDataFixturesDoctrineCommand.php#L106

I don't know where else Connection::getDatabase() gets called, but I'm figuring that returning the path is always a good idea :-)

The query syntax is taken from https://stackoverflow.com/a/44279467/1668200

[morozov]

SQLite doesn't support the concept of a database. Instead, we should consider throwing an exception there. See #4963 for more details.

[ThomasLandauer]

My first question is: Since the fixtures command did work until recently, was there a change here in DBAL or in the fixtures bundle? I couldn't figure anything out in GitHub's history :-(

For the larger topic: The main question I'm seeing is: If somebody is calling Connection::getDatabase(), which information are they looking for? I would say: They want to know where their stuff is being written to! So while I'm seeing your point that semantically this isn't 100% correct: What harm does it do if you just return that path?

[morozov]

Since the fixtures command did work until recently, was there a change here in DBAL or in the fixtures bundle?

The relevant change in the DBAL was released in 3.0.0 (see #3606 for more details).

What harm does it do if you just return that path?

This behavior wouldn't be portable. Each method has its semantics, and a database has a certain meaning in the DBAL. The SQLite platform doesn't support these semantics, so returning something from this method which is not a database may help solve some cases but become an unpleasant surprise in others.

If a tool wants to display an informational message, it should do so based on the connection configuration.

[ThomasLandauer]

OK, thanks, so I'm closing here in favor of doctrine/DoctrineFixturesBundle#359 :-)