Safe array cast to be sure that we are consistent in interfaces … #302
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
This was introduced in #260 . It looks funny to me that we have to do this… isn't there a way to consistently have an array when calling |
Member
|
Also, looks like the build is broken on at least master and 3.3.x, because of a test that depends on a classname that changed after the last version of the persistence lib was released |
Safe array cast to be sure that we are consistent in interfaces on a way from InputInterface::getOption() to ::getFixtures(). Fixes #301
greg0ire
changed the title
Member
|
@Codealist why is this necessary? From looking at the code, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…on a way from InputInterface::getOption() to ::getFixtures()
Fixes #301