Wire up type aliases support in EntityValueResolver #1790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NanoSector
force-pushed
the
feature/type-aliases-support
branch
from
f748096 to
18f1ca0
Compare
NanoSector
force-pushed
the
feature/type-aliases-support
branch
from
18f1ca0 to
142a3df
Compare
|
@ostrolucky Sorry to bother you, I am wondering if any action is required on my part, considering the PR still has 'on hold' status? Its Symfony counterpart is marked as ready. |
|
It's onhold because upstream PR is not merged yet |
ostrolucky
force-pushed
the
2.13.x
branch
3 times, most recently
from
abb5de0 to
2983fa7
Compare
ostrolucky
force-pushed
the
2.13.x
branch
2 times, most recently
from
01c7700 to
7bfb8e8
Compare
NanoSector
commented
Mar 24, 2025
This is an addendum to PR symfony/symfony#51765 in the Symfony Doctrine Bridge, which adds type alias support to EntityValueResolver. This code injects the doctrine.orm.resolve_target_entities configuration into the EntityValueResolver class.
NanoSector
force-pushed
the
feature/type-aliases-support
branch
from
142a3df to
27c31c3
Compare
|
@ostrolucky The upstream PR has been merged; is there anything left to do on my side? |
ostrolucky
removed
the
Status: On Hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an addendum to PR symfony/symfony#54545 targeted at issue symfony/symfony#51765 in the Symfony Doctrine Bridge, which adds type alias support to EntityValueResolver.
This code injects the doctrine.orm.resolve_target_entities configuration into the EntityValueResolver class.