Use getFieldValue and setFieldValue methods #2966
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ker0x
force-pushed
the
get-set-field-value
branch
from
beb13b3 to
7f1cdf6
Compare
ker0x
force-pushed
the
get-set-field-value
branch
from
7f1cdf6 to
f12ac1e
Compare
|
Can you add a test fixture covering the "generate a slug using an embeddable object" scenario? It looks like all the tests only use fields directly on the model and nothing with a relation or embed, so it'd probably be good to have this covered as well. |
|
@mbabker test added 👍 ! |
ro0NL
approved these changes
Jul 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace call to
getReflectionProperty($field)->getValue($entity)andgetReflectionProperty($field)->setValue($entity, $value)withgetFieldValue()andsetFieldValue()methods which are available in both ORM 2.x and 3.xThis makes it possible to use the new
propertyAccessorproperty introduced in ORM 3.4 and fallback toreflFieldswith ORM < 3.4PR contain patch #2945 and also fix #2965