-
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
feat: Add Right-to-Left (RTL) layout support #2551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ssuvamm
wants to merge
1
commit into
docsifyjs:develop
Choose a base branch
from
ssuvamm:feat/rtl-support
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,3 +11,4 @@ | |
@import '_util.css'; | ||
@import '_mq.css'; | ||
@import '_classes.css'; | ||
@import '_rtl.css'; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
/* RTL specific styles */ | ||
body.rtl { | ||
direction: rtl; | ||
text-align: right; | ||
} | ||
|
||
/* Adjust sidebar for RTL */ | ||
body.rtl .sidebar { | ||
left: auto; | ||
right: 0; | ||
} | ||
|
||
body.rtl .content { | ||
margin-left: auto; | ||
margin-right: 300px; /* Assuming default sidebar width is 300px */ | ||
} | ||
|
||
body.rtl .app-nav { | ||
left: auto; | ||
right: 0; | ||
} | ||
|
||
/* Add more specific RTL adjustments as needed */ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,46 @@ | ||
import docsifyInit from '../helpers/docsify-init.js'; | ||
import { test, expect } from './fixtures/docsify-init-fixture.js'; | ||
|
||
test.describe('RTL Mode', () => { | ||
test('should render in RTL mode when rtl:true is set', async ({ page }) => { | ||
// Initialize docsify with RTL configuration | ||
await docsifyInit({ | ||
config: { | ||
rtl: true, | ||
// Add a sidebar to ensure it's rendered and we can test its position | ||
loadSidebar: true, | ||
}, | ||
markdown: { | ||
homepage: '# Test RTL Page', | ||
sidebar: ` | ||
* [Home](/) | ||
* [Page2](/page2) | ||
`, | ||
}, | ||
// _logHTML: true, // Uncomment for debugging if needed | ||
}); | ||
|
||
// Check if body has 'rtl' class | ||
await expect(page.locator('body')).toHaveClass(/rtl/); | ||
|
||
// Check sidebar visibility and position | ||
const sidebar = page.locator('.sidebar'); | ||
await expect(sidebar).toBeVisible(); | ||
|
||
// Check computed style for sidebar position | ||
// This is generally more robust than bounding box calculations if CSS is clear | ||
await expect(sidebar).toHaveCSS('right', '0px'); | ||
|
||
// Optional: Bounding box check (can be more fragile due to scrollbars, etc.) | ||
// const sidebarBoundingBox = await sidebar.boundingBox(); | ||
// const viewportWidth = page.viewportSize().width; | ||
// expect(sidebarBoundingBox.x + sidebarBoundingBox.width).toBeCloseTo(viewportWidth, 2); // Allow 2px tolerance | ||
|
||
// Check content area position (to ensure it's not overlapping with the right-aligned sidebar) | ||
const content = page.locator('.content'); | ||
await expect(content).toBeVisible(); | ||
// The CSS for .content in RTL is `margin-right: 300px;` | ||
// We can check if its left side is not at 0, or its right margin is indeed 300px | ||
await expect(content).toHaveCSS('margin-right', '300px'); | ||
}); | ||
}); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of adding a class, what about using the
dir
attribute?<html dir="rtl">
and target the changes in the layout using that as the selector?[dir=rtl] .layout