Repository navigation
chore(store): drop spf13/cobra dependency and the keychain example CLI - #720
Merged
Merged
Conversation
docker-agent
left a comment
Contributor
There was a problem hiding this comment.
Assessment: 🟡 NEEDS ATTENTION
Lower-confidence findings (not posted inline)
- [low] store/keychain/cmd/main.go:114 — parse error from
store/set/saveFlagSet printed twice (confidence: not scored — low severity, not verified) - [low] store/keychain/cmd/main.go:119 —
storewith no flags silently accepts empty username/password (confidence: not scored — low severity, not verified)
Benehiko
force-pushed
the
chore/drop-cobra-from-store
branch
from
October 29, 2026 15:56
611f4b2 to
3d2d218
Compare
docker-agent
left a comment
Contributor
There was a problem hiding this comment.
Assessment: 🟢 APPROVE
Lower-confidence findings (not posted inline)
- [low] store/keychain/cmd/main.go:137 —
store --helpprints global usage instead of subcommand-specific flag help (unverified; low severity) - [low] store/keychain/cmd/main.go:140 — return value of
fs.Parsesilently discarded withflag.ExitOnError(unverified; low severity, safe for now but fragile if error-handling mode changes)
cobra was only used by the example CLI in store/keychain/cmd. Remove the example and point the keychain README to the docker pass commands in plugins/pass/commands, which use the keychain store. Add a README under plugins/pass on using the pass CLI and embedding its commands. This removes cobra, pflag, and mousetrap from the store module. Signed-off-by: Alano Terblanche <18033717+Benehiko@users.noreply.github.com>
Benehiko
force-pushed
the
chore/drop-cobra-from-store
branch
from
October 29, 2026 16:03
3d2d218 to
77f97e7
Compare
joe0BAB
approved these changes
Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
spf13/cobra was only used by the example CLI in store/keychain/cmd, yet it put cobra, pflag and mousetrap in the store module's go.mod.
The example duplicated what the docker pass commands already show, so this removes it instead of rewriting it:
go.mod/go.sum were edited by hand; make mod may adjust go.sum.
AI disclosure: I used alki, an AI coding agent running Claude, for most of this change: the rebase, removing the example, writing both README changes, and drafting this description. I reviewed the result.