-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add moderate way to retry docker login failures #849
Open
fedordikarev
wants to merge
22
commits into
docker:master
Choose a base branch
from
neondatabase-labs:feat/add-retries
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+150
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Fedor Dikarev <[email protected]>
Signed-off-by: Fedor Dikarev <[email protected]>
Signed-off-by: Fedor Dikarev <[email protected]>
Signed-off-by: Fedor Dikarev <[email protected]>
Signed-off-by: Fedor Dikarev <[email protected]>
Signed-off-by: Fedor Dikarev <[email protected]>
Signed-off-by: Fedor Dikarev <[email protected]>
Signed-off-by: Fedor Dikarev <[email protected]>
Signed-off-by: Fedor Dikarev <[email protected]>
Signed-off-by: Fedor Dikarev <[email protected]>
Signed-off-by: Fedor Dikarev <[email protected]>
Signed-off-by: Fedor Dikarev <[email protected]>
Signed-off-by: Fedor Dikarev <[email protected]>
Signed-off-by: Fedor Dikarev <[email protected]>
Signed-off-by: Fedor Dikarev <[email protected]>
Signed-off-by: Fedor Dikarev <[email protected]>
Signed-off-by: Fedor Dikarev <[email protected]>
Signed-off-by: Fedor Dikarev <[email protected]>
Signed-off-by: Fedor Dikarev <[email protected]>
Signed-off-by: Fedor Dikarev <[email protected]>
Signed-off-by: Fedor Dikarev <[email protected]>
Signed-off-by: Fedor Dikarev <[email protected]>
fedordikarev
force-pushed
the
feat/add-retries
branch
from
January 24, 2025 12:34
fce3de6
to
810869f
Compare
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #750
Ref: https://github.com/neondatabase/cloud/issues/20164
Current problem:
that mechanism at the same time should be conservative, not adding extra unneeded load to DockerHub or another Registry, so for example we shouldn't retry "Bad credentials", we should have timeouts, and reasonable max_attempts
so with that approach:
Please let me know if it's good approach or if anything should be adjusted to be accepted