Skip to content

Conversation

@mnottale
Copy link

No description provided.

@GordonTheTurtle
Copy link

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "memo-backend" [email protected]:infinit/libkv.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

@mnottale mnottale force-pushed the memo-backend branch 3 times, most recently from 645556c to 15fd92e Compare July 24, 2017 09:32
@Dimrok
Copy link

Dimrok commented Jul 27, 2017

Hi @mnottale.

Could you add some tests, like the other backends please (e.g. zookeeper_test, etcd_test, etc.).

@mnottale mnottale force-pushed the memo-backend branch 5 times, most recently from 090539b to 18a2759 Compare August 10, 2017 10:56
@Dimrok
Copy link

Dimrok commented Aug 17, 2017

Hi @mnottale.

seems good but could you create different PRs for each separate problems you fixed, because:

Matthieu Nottale added 7 commits August 21, 2017 11:52
Signed-off-by: Matthieu Nottale <[email protected]>
Signed-off-by: Matthieu Nottale <[email protected]>
Signed-off-by: Matthieu Nottale <[email protected]>
Signed-off-by: Matthieu Nottale <[email protected]>
Signed-off-by: Matthieu Nottale <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants