Remove edge documentation #8006
Conversation
thaJeztah
added
area/engine
|
Deploy preview for docsdocker ready! Built with commit b7c1ac8 |
thaJeztah
force-pushed
the
remove_edge_reference_docs
branch
from
7db2ca4 to
b0106ca
Compare
|
ping @ahh-docker @seemethere @L-Hudson PTAL; I think this one should be ready for review; I kept commits logically grouped; please use merge instead of squash and merge to preserve the information from these commits. |
Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
remove_edge_reference_docs
branch
from
b0106ca to
29daef1
Compare
| docker_ce_stable_version: "18.09" | ||
| docker_ce_edge_version: "18.09" | ||
| latest_engine_api_version: "1.39" | ||
| docker_ce_version: "18.09" | ||
| docker_ee_version: "18.09" |
There was a problem hiding this comment.
FWIW; was thinking of combining the two variables above to just engine_version (given that these only hold the major version, and those are in sync now), but left that for a possible follow-up
There was a problem hiding this comment.
I like the idea of having one variable for Engine version.
There was a problem hiding this comment.
I'll do it in a follow-up; if we reserve this variable for the major (YY.MM) version only, that should work; we may need to keep a separate variable if we want to keep track of patch releases possibly, but I don't think we currently do.
There was a problem hiding this comment.
We have page variables for DTR and UCP that represent major.minor versioning, but I haven't seen an instance for Engine. We could double-check though, but I don't think it will be an issue.
|
@L-Hudson PTAL |
Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
remove_edge_reference_docs
branch
from
29daef1 to
b7c1ac8
Compare
|
Just to be sure (I see the default is "squash and merge");
|
ghost
removed
the
|
Not sure if the continuous-integration/jenkins/pr-merge check is necessary. But this is good to merge. |
|
Asked about that yesterday; and looks like the |
Proposed changes
Unreleased project version (optional)
Related issues (optional)