Skip to content

security: settings reporting reference table #22444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Apr 29, 2025
Merged

security: settings reporting reference table #22444

merged 11 commits into from
Apr 29, 2025

Conversation

sarahsanders-docker
Copy link
Collaborator

@sarahsanders-docker sarahsanders-docker commented Apr 16, 2025 •
edited
Loading

Description

Related issues or tickets

Reviews

  • Editorial review
  • Product review

@netlify Netlify
Copy link

netlify bot commented Apr 16, 2025 •
edited
Loading

✅ Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit 208300a
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/680f7a4933ea0a0008144379
😎 Deploy Preview https://deploy-preview-22444--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added area/security hugo Updates related to hugo labels Apr 16, 2025
@sarahsanders-docker sarahsanders-docker requested review from ajthilakan and a team April 22, 2025 18:08
@sarahsanders-docker sarahsanders-docker marked this pull request as ready for review April 22, 2025 18:08
@sarahsanders-docker sarahsanders-docker changed the title draft: settings reporting reference table security: settings reporting reference table Apr 22, 2025
aevesdocker
aevesdocker reviewed Apr 23, 2025
View reviewed changes
Copy link
Contributor

@aevesdocker aevesdocker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tricky stuff to communicate clearly, but I think the table works 👍 Added some minor nits

@sarahsanders-docker sarahsanders-docker added the status/do-not-merge Pull requests that are awaiting some event or decision before they can be merged. label Apr 23, 2025
aevesdocker
aevesdocker previously approved these changes Apr 24, 2025
View reviewed changes
Copy link
Contributor

@aevesdocker aevesdocker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sarahsanders-docker
Copy link
Collaborator Author

@pla-sam @aevesdocker made some updates to align with the correct UI statuses

aevesdocker
aevesdocker approved these changes Apr 28, 2025
View reviewed changes
Copy link
Contributor

@aevesdocker aevesdocker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sarahsanders-docker sarahsanders-docker merged commit 9362a99 into docker:main Apr 29, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajthilakan ajthilakan Awaiting requested review from ajthilakan

@pla-sam pla-sam Awaiting requested review from pla-sam

@aevesdocker aevesdocker Awaiting requested review from aevesdocker aevesdocker is a code owner

Assignees
No one assigned
Labels
area/security hugo Updates related to hugo status/do-not-merge Pull requests that are awaiting some event or decision before they can be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sarahsanders-docker @aevesdocker