-
Notifications
You must be signed in to change notification settings - Fork 7.6k
docs: added a guide for Dockerized React.js 19 application #22375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: added a guide for Dockerized React.js 19 application #22375
Conversation
…ge documentation [feat] imrpove build images section [feat] updated the containerize react.js guide [feat] added documentation for how to develop and test react.js application [feat] added files for deploy, ci/cd [feat] added page ci-cd [feat] added deployment documentation for React.js application [feat] improve the react.js guide [feat] improve react.hs documentation to follow the same strcuture
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @kristiyan-velkov. It looks great. I really like the formatting you did for the docker init command. I'm going to steal that for the other guides.
I left a lot of petty style nits. You can refer to the style guide or let me know if any questions. The biggest offender was bolding. Typically, we only use it for UI text.
Co-authored-by: Craig Osterhout <[email protected]>
Co-authored-by: Craig Osterhout <[email protected]>
Co-authored-by: Craig Osterhout <[email protected]>
Co-authored-by: Craig Osterhout <[email protected]>
Co-authored-by: Craig Osterhout <[email protected]>
Co-authored-by: Craig Osterhout <[email protected]>
Co-authored-by: Craig Osterhout <[email protected]>
Co-authored-by: Craig Osterhout <[email protected]>
Co-authored-by: Craig Osterhout <[email protected]>
Co-authored-by: Craig Osterhout <[email protected]>
Co-authored-by: Craig Osterhout <[email protected]>
Co-authored-by: Craig Osterhout <[email protected]>
Co-authored-by: Craig Osterhout <[email protected]>
Thanks for the feedback! @craig-osterhout 💯 Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kristiyan-velkov, there are a couple small indention issues I missed on the first review. After fixing those, it's good to go.
@craig-osterhout , Thanks for the heads-up — I’ve fixed the indentation issues. Should be all good now! Let me know if anything else pops up. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
This PR introduces a comprehensive, language-specific guide for containerizing React.js applications using Docker, aimed at helping developers streamline development, testing, and deployment workflows. It includes practical steps and examples to set up CI/CD pipelines using GitHub Actions, aligning with modern DevOps best practices.
What’s Included
Credits
Krisityan Velkov, Docker Captain and experienced Front-end Engineer.