build: add release notes #15621
Merged
build: add release notes #15621
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: CrazyMax <[email protected]>
Signed-off-by: CrazyMax <[email protected]>
Signed-off-by: CrazyMax <[email protected]>
✅ Deploy Preview for docsdocker ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
thaJeztah
reviewed
Sep 11, 2022
| @@ -0,0 +1 @@ | |||
| [{{ include.repo }}#{{ include.number }}](https://github.com/{{ include.repo }}/issues/{{ include.number }}){:target="_blank" rel="noopener" class="_"} | |||
There was a problem hiding this comment.
FWIW; I know we're using it in many places, but the "class" option may not be needed; seems just to make sure the link doesn't have a CSS class assigned (we should even consider doing the reverse, and use a special class for these links)
There was a problem hiding this comment.
Yes many places: https://github.com/docker/docker.github.io/search?q=rel%3D%22noopener%22+class%3D%22_%22 😅. Let's track this for a follow-up.
crazy-max
force-pushed
the
buildx-release-notes-std
branch
from
4e6da32 to
2440f83
Compare
jedevc
previously approved these changes
Sep 12, 2022
|
PTAL @usha-mandya |
crazy-max
force-pushed
the
buildx-release-notes-std
branch
from
2440f83 to
3b85d31
Compare
usha-mandya
reviewed
Sep 12, 2022
usha-mandya
reviewed
Sep 12, 2022
|
@crazy-max Thank you SO much for the updated release notes. Left some minor comments. PTAL and let me know if you have any questions. |
Signed-off-by: CrazyMax <[email protected]>
crazy-max
force-pushed
the
buildx-release-notes-std
branch
from
3b85d31 to
46c597e
Compare
usha-mandya
reviewed
Sep 12, 2022
Signed-off-by: CrazyMax <[email protected]>
crazy-max
force-pushed
the
buildx-release-notes-std
branch
from
70ad8c0 to
7fe2679
Compare
jedevc
approved these changes
Sep 12, 2022
usha-mandya
approved these changes
Sep 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed with @usha-mandya, carry changes from #15291 with standard release notes format while waiting for more inputs with the new one using labels.