Skip to content

refactor(config): remove deprecated safer shell flag from v15 - #4169

Merged
dgageot merged 1 commit into
docker:mainfrom
dgageot:remove-safer-shell-flag-v15
Sep 4, 2026
Merged

refactor(config): remove deprecated safer shell flag from v15#4169
dgageot merged 1 commit into
docker:mainfrom
dgageot:remove-safer-shell-flag-v15

Conversation

@dgageot

@dgageot dgageot commented Sep 4, 2026

Copy link
Copy Markdown
Member

The safer boolean on the shell toolset has been deprecated and ignored for some time: once the runtime started classifying every shell command natively via pkg/safety and gating execution through the session's safety mode, the flag became redundant. This PR removes it from pkg/config/latest (config version 15), which is the only version still open to modification.

Frozen versions v11–v14 are untouched and continue to accept (and silently ignore) the field. For the upgrade path, a version: "14" YAML with safer: true still loads correctly — the v14→v15 migration via types.CloneThroughJSON drops the unknown field. A version: "15" YAML with safer: true is correctly rejected under strict decoding with an unknown field "safer" error.

The change drops Toolset.Safer and its validation check from pkg/config/latest, removes the matching test cases, removes the safer property from agent-schema.json, and updates docs/tools/shell/index.md to drop the option row and note the removal.

@dgageot
dgageot requested a review from a team as a code owner September 4, 2026 12:03
@aheritier aheritier added area/config For configuration parsing, YAML, environment variables area/docs Documentation changes kind/docs Documentation-only changes labels Sep 4, 2026
@dgageot
dgageot merged commit d0ca380 into docker:main Sep 4, 2026
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/config For configuration parsing, YAML, environment variables area/docs Documentation changes kind/docs Documentation-only changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants