fix run --build support for service:* reference in additional_context #13183
+26
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndeloof
force-pushed
the
fix_run_build
branch
6 times, most recently
from
e5b9998 to
5e696a7
Compare
ndeloof
force-pushed
the
fix_run_build
branch
2 times, most recently
from
57b17f0 to
13e5e80
Compare
pzhlkj6612
reviewed
Sep 5, 2025
pkg/compose/build.go
Outdated
| options.Services = project.ServiceNames() | ||
| } | ||
|
|
||
| // also include services used as additional_contexts ith service: prefix |
There was a problem hiding this comment.
Suggested change
| // also include services used as additional_contexts ith service: prefix | |
| // also include services used as additional_contexts with service: prefix |
typo?
ndeloof
force-pushed
the
fix_run_build
branch
from
13e5e80 to
5195364
Compare
glours
reviewed
Sep 8, 2025
pkg/e2e/build_test.go
Outdated
| @@ -32,7 +32,7 @@ import ( | |||
| ) | |||
|
|
|||
| func TestLocalComposeBuild(t *testing.T) { | |||
| for _, env := range []string{"DOCKER_BUILDKIT=0", "DOCKER_BUILDKIT=1", "DOCKER_BUILDKIT=1,COMPOSE-BAKE=1"} { | |||
| for _, env := range []string{"DOCKER_BUILDKIT=0", "DOCKER_BUILDKIT=1,COMPOSE-BAKE=0", "DOCKER_BUILDKIT=1,COMPOSE-BAKE=1"} { | |||
There was a problem hiding this comment.
It should be COMPOSE_BAKE, no?
Suggested change
| for _, env := range []string{"DOCKER_BUILDKIT=0", "DOCKER_BUILDKIT=1,COMPOSE-BAKE=0", "DOCKER_BUILDKIT=1,COMPOSE-BAKE=1"} { | |
| for _, env := range []string{"DOCKER_BUILDKIT=0", "DOCKER_BUILDKIT=1,COMPOSE_BAKE=0", "DOCKER_BUILDKIT=1,COMPOSE_BAKE=1"} { |
Signed-off-by: Nicolas De Loof <[email protected]>
ndeloof
force-pushed
the
fix_run_build
branch
from
5195364 to
36e57d3
Compare
glours
approved these changes
Sep 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
fix run --build support for service:* reference in additional_context
Related issue
fixes #13159
(not mandatory) A picture of a cute animal, if possible in relation to what you did