Skip to content

Remove OpenTelemetry #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 20, 2025
Merged

Remove OpenTelemetry #187

merged 2 commits into from
Mar 20, 2025

Conversation

NelsonVides
Copy link
Contributor

As discussed with @weppos, we don't use this at the moment and it adds a lot of noise in code. Further work will be carried later on instrumentation and if needed this can be re-engineered.

@NelsonVides NelsonVides added the enhancement New feature, enhancement or code changes, not related to defects label Mar 19, 2025
@NelsonVides NelsonVides self-assigned this Mar 19, 2025
@weppos weppos removed request for weppos and san983 March 19, 2025 11:42
DXTimer
DXTimer approved these changes Mar 20, 2025
View reviewed changes
Copy link
Contributor

@DXTimer DXTimer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I support removing OTEL from the codebase as it's no longer useful for our needs. However, since this is a public package, we should:

  1. Clearly communicate this change to users
  2. Document it in a Changelog entry for the main branch

@NelsonVides NelsonVides merged commit 50ced0f into main Mar 20, 2025
5 checks passed
@NelsonVides NelsonVides deleted the remove_opentelemetry branch March 20, 2025 07:07
@weppos weppos changed the title Remove opentelemetry, as it is not used Remove OpenTelemetry Mar 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DXTimer DXTimer DXTimer approved these changes

@m0rcq m0rcq Awaiting requested review from m0rcq

Assignees

@NelsonVides NelsonVides

Labels
enhancement New feature, enhancement or code changes, not related to defects
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NelsonVides @DXTimer