fix(pi-fff): cap collapsed output by rendered lines#691
Open
GitHubFoxy wants to merge 1 commit into
Open
Conversation
Owner
|
I'm a big unsure what problem you are trying to solve? Why do you think the output is bound to terminal lines if this is pure text (or you mean the actual PI render output)? |
Author
Owner
|
I'm not sure why do you think this is necessarily bad, the line context is capped to 512 characters on the sdk level to give some context around the line |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Long output lines, such as JSONL search matches, can wrap across several terminal rows. The previous 15/20 logical-line limits could therefore fill most of the screen even while tool output was collapsed.
Verification
bun --cwd packages/pi-fff test— 45 passing--list-modelssuccessfully