Skip to content

fix(pi-fff): cap collapsed output by rendered lines#691

Open
GitHubFoxy wants to merge 1 commit into
dmtrKovalenko:mainfrom
GitHubFoxy:fix/pi-fff-collapse-rendered-lines
Open

fix(pi-fff): cap collapsed output by rendered lines#691
GitHubFoxy wants to merge 1 commit into
dmtrKovalenko:mainfrom
GitHubFoxy:fix/pi-fff-collapse-rendered-lines

Conversation

@GitHubFoxy

Copy link
Copy Markdown

Summary

  • cap collapsed grep/find/multi-grep output at five rendered terminal rows
  • count wrapped rows rather than only newline-delimited logical lines
  • reserve the final collapsed row for the configured tool-expansion key hint
  • preserve the complete output when expanded

Long output lines, such as JSONL search matches, can wrap across several terminal rows. The previous 15/20 logical-line limits could therefore fill most of the screen even while tool output was collapsed.

Verification

  • bun --cwd packages/pi-fff test — 45 passing
  • loaded the extension through Pi with --list-models successfully

@dmtrKovalenko

Copy link
Copy Markdown
Owner

I'm a big unsure what problem you are trying to solve? Why do you think the output is bound to terminal lines if this is pure text (or you mean the actual PI render output)?

@GitHubFoxy

Copy link
Copy Markdown
Author

Here is what i mean
image

@dmtrKovalenko

@dmtrKovalenko

Copy link
Copy Markdown
Owner

I'm not sure why do you think this is necessarily bad, the line context is capped to 512 characters on the sdk level to give some context around the line

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants