Skip to content

feat(config): add show_root_path option for panel headers#168

Merged
dlyongemallo merged 2 commits into
dlyongemallo:mainfrom
jesses-code-adventures:main
May 11, 2026
Merged

feat(config): add show_root_path option for panel headers#168
dlyongemallo merged 2 commits into
dlyongemallo:mainfrom
jesses-code-adventures:main

Conversation

@jesses-code-adventures
Copy link
Copy Markdown

Adds show_root_path as a boolean option in the file_panel configuration, allowing a user to hide the launch directory at the top of the file panel by passing false.

@dlyongemallo
Copy link
Copy Markdown
Owner

Thanks for the PR!

The files doc/diffview.txt and doc/diffview_defaults.txt should be updated, per the contributing guidelines.

Could make the title a bit more specific: feat(config): ....

Is it intentional to gate this only to the file panel? The file history panel also shows the root path, and it makes sense for a top-level option (i.e., conf.show_root_path) to apply to both. Alternatively, it could remain under file_panel with the equivalent option under file_history_panel, but I don't think there's a real use case for hiding it in one panel but not the other.

@jesses-code-adventures jesses-code-adventures changed the title feat: show_root_path in file_panel configuration feat(config): show_root_path in file_panel configuration May 11, 2026
@jesses-code-adventures
Copy link
Copy Markdown
Author

My pleasure @dlyongemallo ! Thanks for taking over maintenance of this project, really appreciate your work. I've applied the changes you requested, let me know if there's anything else.

@dlyongemallo dlyongemallo changed the title feat(config): show_root_path in file_panel configuration feat(config): add show_root_path to allow hiding the directory in the file and file history panels May 11, 2026
@dlyongemallo dlyongemallo changed the title feat(config): add show_root_path to allow hiding the directory in the file and file history panels feat(config): add show_root_path option for panel headers May 11, 2026
@dlyongemallo dlyongemallo merged commit af3dd07 into dlyongemallo:main May 11, 2026
7 checks passed
@dlyongemallo
Copy link
Copy Markdown
Owner

@jesses-code-adventures I've merged it. Thanks again for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants