fix: focus diffview when showFileTree is false#130
Merged
Conversation
On startup, if the config option `showFileTree` is false, the panel is collapsed and it's a weird UI experience that it is focused despite being collapsed. Focus the diff panel on startup instead Also add a test
dlvhdr
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On startup, if the config option
showFileTreeis false, the panel iscollapsed and it's a weird UI experience that it is focused despite
being collapsed. Focus the diff panel on startup instead
AI disclosure
I used pi and anthropic, but fully understood the patch
How Did You Test this Change?
I tested the updated
diffnavwith the code in this PR and verified it focusedthe diff when started with the
showFileTreeconfig option enabled