Added exit on esc#126
Open
BitPeppr wants to merge 2 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Adds Esc as an additional quit keybinding to align with the existing q/Ctrl+C quit behavior and close issue #91.
Changes:
- Extend the global quit keybinding to include
esc.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
escapekeybind to quit. #91Changes
Pressing esc will quit the application, similar to pressing q — if there is a popup message, it simply exits / closes the popup — as described by jcollie in issue #91. This is a very minor change, but I hope it's helpful. I understand that this may be configurable, but since the issue was never closed, I thought I would open a pr just in case it's considered a good change.