Skip to content

Fix: Prevent build conflicts by cleaning up stale library files #3068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix: Prevent build conflicts by cleaning up stale library files #3068

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 29 additions & 0 deletions source/dub/generators/build.d
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,6 +252,32 @@ class BuildGenerator : ProjectGenerator {
return cached;
}

// Deletes any old library build artifacts (.a, .lib, .so) from the specified build path.
// This is done to ensure a clean build and prevent issues from stale or partial files.
private void cleanupLibraryFiles(NativePath buildPath)
{
import std.path : extension;
import std.file : dirEntries, remove, SpanMode;

if(std.file.exists(buildPath.toNativeString()))
{
logDiagnostic("Deleting old build artifacts from %s..." , buildPath.toNativeString());

foreach (entry; std.file.dirEntries(buildPath.toNativeString() , SpanMode.shallow))
{
if(entry.isFile){
auto fileExtension = extension(entry.name);
if(fileExtension == ".a" || fileExtension == ".lib" || fileExtension == ".so")
{
auto fullPath = buildPath.toNativeString() ~ entry.name;
std.file.remove(fullPath);
}
}
}
}

}

private bool performCachedBuild(GeneratorSettings settings, BuildSettings buildsettings, in Package pack, string config,
string build_id, in Package[] packages, in NativePath[] additional_dep_files, out NativePath target_binary_path)
{
Expand Down Expand Up @@ -280,6 +306,9 @@ class BuildGenerator : ProjectGenerator {
return false;
}

// Clean up any existing library files from the previous build to ensure a fresh start.
cleanupLibraryFiles(target_path);

logInfo("Building", Color.light_green, "%s %s: building configuration [%s]", pack.name.color(Mode.bold), pack.version_, config.color(Color.blue));

if( buildsettings.preBuildCommands.length ){
Expand Down