Skip to content

Replace TimeDateStamp with deterministic hash for reproducible builds #21191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

abulgit
Copy link
Contributor

@abulgit abulgit commented Apr 9, 2025

fixes: #21095
I replaced the time-based TimeDateStamp in mscoffobj.d files with a deterministic hash derived from the object file's content.
Implemented a deterministic hash generation system using Blake3.
Used the first 4 bytes of the resulting hash as the TimeDateStamp value.

For Testing -
I compiled the same code at different times, and the object file was the same hash.

abulk@MSI MINGW64 ~/OneDrive/Desktop/hash
$ certutil -hashfile prog1.obj SHA256
SHA256 hash of prog1.obj:
9319df865f216e72e0f63407cae7e00ed08ae00e7b8a486ab34780a60020ec9a
CertUtil: -hashfile command completed successfully.

abulk@MSI MINGW64 ~/OneDrive/Desktop/hash
$ certutil -hashfile prog2.obj SHA256
SHA256 hash of prog2.obj:
9319df865f216e72e0f63407cae7e00ed08ae00e7b8a486ab34780a60020ec9a
CertUtil: -hashfile command completed successfully.

Copy link
Contributor

@dkorpel dkorpel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @abulgit! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#21191"

@abulgit abulgit requested a review from dkorpel April 10, 2025 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TimeDateStamp in object files should be a deterministic hash
3 participants