-
-
Notifications
You must be signed in to change notification settings - Fork 379
Mention relation of interfaces to member fields #3104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
christoph-ehm
wants to merge
8
commits into
dlang:master
Choose a base branch
from
christoph-ehm:patch-3
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
639258b
Mention relation of interfaces to member fields
christoph-ehm 5d7830e
Update wording in interface explanation, spec/interface.dd
christoph-ehm f573d76
Add missing apostrophy to spec/interface.dd
christoph-ehm c94a857
Add further examples to spec/interface.dd
christoph-ehm 347f1f6
templated member -> member template
christoph-ehm cf4e9b8
static member fields don't override interface
christoph-ehm 822d405
change behaviour -> behavior
christoph-ehm 3e3407a
Add definition rule for implicitly final members
christoph-ehm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This and the previous sentence should probably be joined together. The "it's" is a bit jarring.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe: "An Interface abstracts from behaviour in terms of an abstract class which ..."
I originally intended to use simple English but less text is surely reasonable as long as it's comprehensible.
If you have write access to this PR, you are welcome to do the change. I can do this only later on another device.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@maxhaton I integrated your changes with my ones.