Skip to content

#1482 - Delete function for AlignedString does not work properly - #1645

Merged
reckart merged 1 commit into
mainfrom
bugfix/1482-Delete-function-for-AlignedString-does-not-work-properly
Aug 9, 2026
Merged

#1482 - Delete function for AlignedString does not work properly#1645
reckart merged 1 commit into
mainfrom
bugfix/1482-Delete-function-for-AlignedString-does-not-work-properly

Conversation

@reckart

@reckart reckart commented Aug 9, 2026

Copy link
Copy Markdown
Member

What's in the PR

  • Fix AlignedString.delete() losing position markers for mid-segment deletions
  • Fix fireChange() not propagating transitively through stacked AlignedString levels
  • Fix delete(p, p) throwing NPE when start equals end
  • Add collapse() mechanism to ObliqueSegment to retain zero-length position markers after deletion
  • Add dropDuplicateMarkers() to suppress redundant zero-length markers at identical underlying positions
  • Remove stray System.out.println() from updateCaches() method
  • Add regression tests for multi-region deletion, transitive change propagation, and empty-range deletion

How to test manually

  • See issue description

Automatic testing

  • PR includes unit tests

Documentation

  • PR updates documentation

@reckart reckart added this to the 3.0.0 milestone Aug 9, 2026
@reckart reckart self-assigned this Aug 9, 2026
@reckart reckart added this to Kanban Aug 9, 2026
@reckart reckart added 🐛Bug Something isn't working Module-api.transform labels Aug 9, 2026
@github-project-automation github-project-automation Bot moved this to In progress in Kanban Aug 9, 2026
- Fix AlignedString.delete() losing position markers for mid-segment deletions
- Fix fireChange() not propagating transitively through stacked AlignedString levels
- Fix delete(p, p) throwing NPE when start equals end
- Add collapse() mechanism to ObliqueSegment to retain zero-length position markers after deletion
- Add dropDuplicateMarkers() to suppress redundant zero-length markers at identical underlying positions
- Remove stray System.out.println() from updateCaches() method
- Add regression tests for multi-region deletion, transitive change propagation, and empty-range deletion
@reckart
reckart force-pushed the bugfix/1482-Delete-function-for-AlignedString-does-not-work-properly branch from a35a27a to e1cd042 Compare August 9, 2026 10:14
@reckart
reckart merged commit 1098985 into main Aug 9, 2026
5 checks passed
@reckart
reckart deleted the bugfix/1482-Delete-function-for-AlignedString-does-not-work-properly branch August 9, 2026 11:44
@github-project-automation github-project-automation Bot moved this from In progress to Done in Kanban Aug 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐛Bug Something isn't working Module-api.transform

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant