#334 - Add more type annotations - #361
Merged
Merged
Conversation
- Add lxml-stubs dev dependency for improved type checking of lxml code - Fix incorrect return type on `_serialize_float_value` (was `Union[float, str]`, always returns `str`) - Fix incorrect `etree._ElementTree` call to use public `etree.ElementTree` factory - Introduce module-level `Element` type alias for `etree._Element` to avoid private-usage warnings in annotations - Update XMI serializer to pass `attrib=` explicitly instead of unpacking dict as `**kwargs` for type safety - Update element parameter annotations to use `Optional[Element]` where applicable to match actual caller behavior
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's in the PR
_serialize_float_value(wasUnion[float, str], always returnsstr)etree._ElementTreecall to use publicetree.ElementTreefactoryElementtype alias foretree._Elementto avoid private-usage warnings in annotationsattrib=explicitly instead of unpacking dict as**kwargsfor type safetyOptional[Element]where applicable to match actual caller behaviorHow to test manually
Automatic testing
Documentation