#334 - Add more type annotations - #358
Merged
Merged
Conversation
- Replace builtin `any` with `typing.Any` in Dict type annotations across json.py - Correct return types for properties that can be None: sofaString, sofa_mime, sofa_uri, document_language (cas.py), get_covered_text (typesystem.py) - Fix invalid type syntax for _parse_primitive_array parameter (change from `[list, str]` to `Union[list, str]`) - Update _parse_primitive_array return type to Union[list, bytes] to match actual return paths - Update _serialize_ref return type to Optional[int] (can return None) - Remove incorrect `-> str` return annotation from document_language setter (setters return None) - Rename duplicate nested function parse_and_add to parse_and_add_entry in dict branch to fix redeclaration error - Wrap dict_values in iter() for TypeSystem.get_types() to maintain Iterator contract
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's in the PR
anywithtyping.Anyin Dict type annotations across json.py[list, str]toUnion[list, str])-> strreturn annotation from document_language setter (setters return None)How to test manually
Automatic testing
Documentation