chore(deps-dev): bump wp-coding-standards/wpcs from 3.3.0 to 3.4.1 in the composer group across 1 directory - #70
Merged
Conversation
Bumps the composer group with 1 update in the / directory: [wp-coding-standards/wpcs](https://github.com/WordPress/WordPress-Coding-Standards). Updates `wp-coding-standards/wpcs` from 3.3.0 to 3.4.1 - [Release notes](https://github.com/WordPress/WordPress-Coding-Standards/releases) - [Changelog](https://github.com/WordPress/WordPress-Coding-Standards/blob/develop/CHANGELOG.md) - [Commits](WordPress/WordPress-Coding-Standards@3.3.0...3.4.1) --- updated-dependencies: - dependency-name: wp-coding-standards/wpcs dependency-version: 3.4.1 dependency-type: direct:development dependency-group: composer ... Signed-off-by: dependabot[bot] <support@github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #70 +/- ##
=======================================
Coverage 81.01% 81.01%
=======================================
Files 43 43
Lines 3113 3113
Branches 522 522
=======================================
Hits 2522 2522
Misses 185 185
Partials 406 406 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
dknauss
approved these changes
Aug 2, 2026
dknauss
left a comment
Owner
There was a problem hiding this comment.
Dev-dependency bump, CI fully green. Approving.
dknauss
added a commit
that referenced
this pull request
Aug 3, 2026
The doc was last verified 2026-07-05 at 49f623b; #66, #67, #68 and #70 have landed since. Re-derive every figure with the command the doc itself documents. Lines of code moved with the BAC v4 integration: main plugin file 1,881 -> 1,928, all first-party PHP 1,979 -> 2,026, JS source 8,851 -> 8,802. The installed footprint is smaller than recorded rather than larger: release vendor/ 792 KB (was documented ~1.0 MB), total ~1.9 MB (was ~2.1 MB), and the distributed ZIP ~461 KB (was ~0.9-1 MB). The ZIP was checked for completeness -- 242 entries, unzip -t clean, all citeproc and CSL payloads present -- so this is a real reduction, not a short archive. Record the exact byte count alongside the rounded figure so the next check is unambiguous. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
dknauss
added a commit
that referenced
this pull request
Aug 3, 2026
…t never ran (#71) * docs: record BAC v4 integration and document the 4.0+ requirement PR #68 updated the Block Accessibility Checks integration for BAC 4.0 but left no changelog trace, and readme.txt had no unreleased section at all. Record both, along with the docs/current-metrics.md addition from #67. BAC 4.0 replaced the registration API, so Borges now needs that plugin at 4.0+ for its four checks to load. On 3.x the function_exists guard makes the integration a silent no-op, which is invisible to the user, so state the requirement in the readme description, a new FAQ entry, and README.md. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * docs: refresh current-metrics.md against main HEAD The doc was last verified 2026-07-05 at 49f623b; #66, #67, #68 and #70 have landed since. Re-derive every figure with the command the doc itself documents. Lines of code moved with the BAC v4 integration: main plugin file 1,881 -> 1,928, all first-party PHP 1,979 -> 2,026, JS source 8,851 -> 8,802. The installed footprint is smaller than recorded rather than larger: release vendor/ 792 KB (was documented ~1.0 MB), total ~1.9 MB (was ~2.1 MB), and the distributed ZIP ~461 KB (was ~0.9-1 MB). The ZIP was checked for completeness -- 242 entries, unzip -t clean, all citeproc and CSL payloads present -- so this is a real reduction, not a short archive. Record the exact byte count alongside the rounded figure so the next check is unambiguous. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * ci: gate docs/current-metrics.md against drift The metrics doc is hand-verified and had gone stale across three merges with nothing to catch it. Add verify-metrics.sh, wired into the Quality job and exposed as composer verify:metrics, so drift fails CI instead. The gate checks the three lines-of-code figures and re-runs the persistence/hook audit that underpins the zero-query runtime claim. It deliberately does not assert the du-based footprint figures or built asset byte sizes: du reports allocated blocks and differs between macOS and the Linux runner, and webpack output is only byte-stable for a fixed toolchain. Asserting those would produce failures that say nothing about the repository, so they stay hand-verified and the script says so. Placed before the build steps so it cannot false-fail on a checkout with no build artifacts. Verified in both directions: exit 0 on a clean tree, exit 1 on a perturbed figure and on an introduced update_option call. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * test(a11y): make the BAC integration test actually run The accessibility Playground booted with no blueprint, so Block Accessibility Checks was never installed, so the test that covers the BAC integration skipped itself on every run -- including CI, which still reported green. The integration shipped in #68 had no end-to-end coverage at all, which matters because BAC 4.0 silently ignores hooks registered under their pre-4.0 names: every check just passes. Install BAC in the a11y environment and assert against the block-accessibility-checks data store rather than BAC's markup. The old assertions targeted .ba11y-block-indicator--error/--warning, classes v4 removed in favour of a validation toolbar button, so the negative assertions could not have failed. Verified in both directions: renaming the editor filter back to ba11yc_validate_block makes the test fail. Installing BAC also exposed a race in the publish helper. BAC registers an error-level post_title_required editor check that holds core's post-saving lock while the title is empty; the helper set the title and saved in the same tick and the save was rejected. This is not a Borges defect -- a plain paragraph post with no bibliography block fails the same way, and publishing through the UI works. Wait for the lock to lift, and verify the post reached publish instead of returning an auto-draft permalink that 404s later in the test. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * fix(security): resolve PMID records through wp_safe_remote_get The PMID resolver follows up to three redirects. wp_remote_get follows them anywhere, including a host on the site's own network; only wp_safe_remote_get runs each hop through wp_http_validate_url. The exposure was narrow -- the PMID is validated against ^\\d{1,8}$ before use and the endpoint host is a fixed constant, so the redirect chain was the one part of the request an upstream change could have pointed somewhere unintended -- but the safe variant is the correct default for an outbound call the plugin does not fully control. The test bootstrap now records which HTTP helper a call reached for, so the assertion is on the function rather than only the URL, and fails if the call site regresses. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * test(a11y): fail rather than skip when BAC is missing in CI The previous commit fixed why the BAC integration test never ran. This fixes how that went unnoticed: the test skipped itself whenever Block Accessibility Checks was absent, and a skip is indistinguishable from a pass on a green run. Keep the graceful skip for local runs without the plugin, but throw when CI is set, naming the blueprint and the script flag to check. If blueprint provisioning ever breaks again, the run goes red instead of quietly reporting success over no coverage. Verified by booting Playground with no blueprint and CI=1: the test fails with the intended message rather than skipping. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps the composer group with 1 update in the / directory: wp-coding-standards/wpcs.
Updates
wp-coding-standards/wpcsfrom 3.3.0 to 3.4.1Release notes
Sourced from wp-coding-standards/wpcs's releases.
Changelog
Sourced from wp-coding-standards/wpcs's changelog.
... (truncated)
Commits
ec2ff94Merge pull request #2773 from WordPress/developb558639Merge pull request #2772 from WordPress/feature/changelog-3.4.11696dc8Changelog for the release of WordPressCS 3.4.1a29048dMerge pull request #2771 from WordPress/security/enqueuedresourceparams-fix-i...7262444WP/EnqueuedResourceParameters: remove eval() from is_falsy()54719c0Merge pull request #2770 from WordPress/feature/composer-update-versions267d84eComposer: update minimum version PHPCSUtils + PHPCSExtrae8064a6AddSECURITY.mdfile (#2766)7ac8973Merge pull request #2768 from WordPress/dependabot/github_actions/action-runn...9466b4bGH Actions: Bump actions/checkout in the action-runners groupDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore <dependency name> major versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)@dependabot ignore <dependency name> minor versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)@dependabot ignore <dependency name>will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)@dependabot unignore <dependency name>will remove all of the ignore conditions of the specified dependency@dependabot unignore <dependency name> <ignore condition>will remove the ignore condition of the specified dependency and ignore conditionsYou can disable automated security fix PRs for this repo from the Security Alerts page.