Refactor stuff #3855
Merged
Refactor stuff #3855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@PieterVdc I was gonna test and merge this in a hurry, but it has merge conflicts. |
This is a spell, also remove the error log to stop it from filling against creatures that are immunes (All spell kind should be supported by now).
walt253
reviewed
Jan 29, 2025
I fixed those conflicts since I introduced them with #3820. |
perfect thanks, also why I did this PR in the first place, to have less new ones in the future on my lua PR |
all good now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
split off from the #2043 Lua PR, mostly reordering some things to make it easier to use with lua later on
PR shouldn't have any functional changes