extend renewal_info() to yield retry-after header #125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think we should yield a Duration rather than a SystemTime. |
christianhoelzl
force-pushed
the
ari_retry_after
branch
from
8e2fcd7 to
022dfac
Compare
|
Changed to Duration. The edge case that the retry-after is in past is treated as a duration with 0 secs. |
Yes, please do that in a separate commit! |
djc
reviewed
Jul 4, 2025
christianhoelzl
force-pushed
the
ari_retry_after
branch
from
022dfac to
f90d7f9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds an extension to the function
Account::renewal_info()to additionally yield the Retry-After header as aSystemTime. Reference is RFC 9773, 4.3.2 Client Handling of Retry-After. TheSystemTimeis a hint from the ACME server when to again fetch the renewal window.