- 
          
- 
                Notifications
    You must be signed in to change notification settings 
- Fork 128
          Add redis-rs feature flags
          #183
        
          New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
  
    Add redis-rs feature flags
  
  #183
              Conversation
| I've understood and used the first option, which is to have both  Metadata errorError: failed to get cargo metadata Caused by:  | 
| Codecov ReportAll modified and coverable lines are covered by tests ✅ 
 
 Additional details and impacted files@@           Coverage Diff           @@
##             main     #183   +/-   ##
=======================================
  Coverage   72.00%   72.00%           
=======================================
  Files           6        6           
  Lines         593      593           
=======================================
  Hits          427      427           
  Misses        166      166           ☔ View full report in Codecov by Sentry. | 
| 
 That is just an aspect of how you've set this up. You can use features with a  | 
| 
 I see. Was doing it that way because I didn't know this is the way to expose upstream's features, so I very naturally want to test it locally, but I guess it is not necessary, after all. | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is almost ready!
| async-trait = "0.1" | ||
| bb8 = { version = "0.8", path = "../bb8" } | ||
| redis = { version = "0.24", default-features = false, features = ["tokio-comp"] } | ||
| redis = { version = "0.24", default-features = false, features = [ | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please revert the formatting change.
| futures-util = "0.3.15" | ||
| tokio = { version = "1.0.0", features = ["macros", "rt-multi-thread"] } | ||
|  | ||
| [features] | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please move the features before the dependencies section.
| Please re-check this with redis v1.0.0-rc , c.f. #263 It would be counter-productive to add a redis 0.x feature that doesnt also exist in redis 1.0 | 
Fixes #146.