Updated django, third party version. #550
Conversation
| @@ -2,7 +2,7 @@ | |||
|
|
|||
| from django import forms | |||
| from django.contrib import admin | |||
| from django.utils.translation import ugettext_lazy as _ | |||
There was a problem hiding this comment.
ugettext_lazy deprecated v3.0
| @@ -3,7 +3,7 @@ | |||
| from django.contrib.contenttypes.models import ContentType | |||
| from django.http import Http404, HttpResponse, HttpResponseBadRequest, HttpResponseNotAllowed, HttpResponseRedirect | |||
| from django.shortcuts import get_object_or_404 | |||
| from django.utils.http import is_safe_url | |||
| from django.utils.http import url_has_allowed_host_and_scheme | |||
There was a problem hiding this comment.
is_safe_url deprecated v3.0
|
Hello! @chriswedgwood, @carltongibson 🙌 I understand that it's ideal to upgrade versions incrementally, but due to interdependencies between libraries, it seems I have to modify the versions of multiple libraries at once. When this change is applied, the server runs, but there are issues with the social login functionality. (There are also some problems with the tests.) I apologize for bothering you when you’re busy, and I’m sorry for mentioning you out of the blue. 😥 |
@Antoliny0919 let me look to start this process of upgrading. The process is a bit of trial and error and making sure all the dependencies work together. So upgrade django one minor version at a time, check if app works , if not upgrade packages that are causing failures, rinse and repeat. Ill get started on this today |
|
The build failure suggests an isort error, so maybe our pre-commit issue is the problem |
Thank you for taking on this task. |
No description provided.