Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix table style for foundation flatpage #1468

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

sabderemane
Copy link
Member

Prior to this change, the foundation page have 2 tables with previous boards which are not responsive and hard to distinguish rows in mobile.

This change add two CSS classes which fixes this issue.

Screenshots 📷

BEFORE

Capture d’écran 2024-01-16 à 01 52 27 Capture d’écran 2024-01-16 à 01 52 45

AFTER

Dark Mode
Capture d’écran 2024-01-16 à 01 41 21
Capture d’écran 2024-01-16 à 01 41 28
Capture d’écran 2024-01-16 à 01 41 42

Light Mode
Capture d’écran 2024-01-16 à 01 44 52
Capture d’écran 2024-01-16 à 01 46 03

Copy link
Member

@thibaudcolas thibaudcolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great @sabderemane. I managed to manually test this but I assume as far as the production change we’ll need to update the HTML in flatpages?

@thibaudcolas thibaudcolas merged commit 23d86df into django:main Jan 17, 2024
@thibaudcolas
Copy link
Member

I was able to answer my own question – and have updated the flatpages’ HTML already. So this should be live once the site is deployed again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants