Fixed #35115 -- Made admin's footer render in <footer> tag.

[MHLut]

Fixes ticket #35115.

Important notes:

• Removes all existing footer CSS per recommendations in the ticket.
• Uses the semantic element plus ID of the same name in the same style as the page header.
• Puts the opening tags inside the block tags, also in the same style as the page header.
• The now-removed CSS clear on the footer did nothing since the parent element is a flexbox.

[github-actions]

Hello! Thank you for your contribution 💪

As it's your first contribution be sure to check out the patch review checklist.

If you're fixing a ticket from Trac make sure to set the "Has patch" flag and include a link to this PR in the ticket!

If you have any design or process questions then you can ask in the Django forum.

Welcome aboard ⛵️!

[felixxm]

I thought we agreed on a different approach 🤔

Suggested change

	{% block footer %}<footer id="footer"></footer>{% endblock %}
	<footer id="footer">{% block footer %}{% endblock %}</footer>

[MHLut]

I'm sorry, I missed Thibaud's +1 on this decision. I disagree on this method for two reasons:

1. It makes the footer element itself not overridable.
2. The other elements, like the page header, also have the element defined within the block, so it feels more consistent to keep it that way.

Should we put this up for discussion here on in the ticket?

[felixxm]

It makes the footer element itself not overridable.

So, exactly the same as situation as with <main>.

[felixxm]

Per Thibaud's comment it looks like we're doing folks a favor by forcing <footer> here:

Is it clear enough to people who would override this, that with it outside main, they’d definitely need to use a <footer> tag? Otherwise their content would be outside a landmark (​https://dequeuniversity.com/rules/axe/4.3/region).

[MHLut]

I put the block tags inside the element.

[felixxm]

We can ask @thibaudcolas for the confirmation, if you want.

[MHLut]

It's OK, either solution has pros and cons, I can understand enforcing the footer tags like this!

[felixxm]

Can you add a small test? For example:

diff --git a/tests/admin_views/tests.py b/tests/admin_views/tests.py
index cb61c88941..429a79c062 100644
--- a/tests/admin_views/tests.py
+++ b/tests/admin_views/tests.py
@@ -1605,6 +1605,10 @@ class AdminViewBasicTest(AdminViewBasicTestCase):
             '<main id="content-start" class="content" tabindex="-1">',
         )
 
+    def test_footer(self):
+        response = self.client.get(reverse("admin:index"))
+        self.assertContains(response, '<footer id="footer">')
+
     def test_aria_describedby_for_add_and_change_links(self):
         response = self.client.get(reverse("admin:index"))
         tests = [

[MHLut]

Thanks. I added a test based on the existing header test!

[felixxm]

@MHLut Thanks 👍 Welcome aboard ⛵

[MHLut]

@felixxm Thank you for the help! Much appreciated.